[llvm] r352378 - VERSION_GREATER_EQUAL not supported in llvm cmake.

Ranjeet Singh via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 07:48:07 PST 2019


Author: rsingh
Date: Mon Jan 28 07:48:07 2019
New Revision: 352378

URL: http://llvm.org/viewvc/llvm-project?rev=352378&view=rev
Log:
VERSION_GREATER_EQUAL not supported in llvm cmake.

Patch https://reviews.llvm.org/D56329 caused build failures for me when
building on Windows because of the use of cmake operator
'VERSION_GREATER_EQUAL' which isn't supported in older versions of cmake. The
llvm website states that minimum required version of cmake for building llvm is
3.4.3 https://llvm.org/docs/CMake.html

Differential Revision: https://reviews.llvm.org/D57326


Modified:
    llvm/trunk/unittests/Support/CMakeLists.txt

Modified: llvm/trunk/unittests/Support/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/CMakeLists.txt?rev=352378&r1=352377&r2=352378&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/CMakeLists.txt (original)
+++ llvm/trunk/unittests/Support/CMakeLists.txt Mon Jan 28 07:48:07 2019
@@ -90,7 +90,7 @@ if(NOT MSVC)
   set_source_files_properties(AlignOfTest.cpp PROPERTIES COMPILE_FLAGS -w)
 endif()
 if(MSVC)
-  if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.15 )
+  if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 19.14 )
     # Since VS2017 15.8, the following snippet: Failed<CustomSubError>()
     # generates a warning:
     # \svn\llvm\utils\unittest\googlemock\include\gmock\gmock-matchers.h(186):




More information about the llvm-commits mailing list