[PATCH] D57326: VERSION_GREATER_EQUAL not supported in llvm's minimum required cmake version

[Ranjeet Singh via Phabricator via llvm-commits]

rs created this revision.
rs added reviewers: dmgreen, aganea.
Herald added subscribers: llvm-commits, mgorny.

Patch https://reviews.llvm.org/D56329 caused build failures for me when building on Windows because of the use of cmake operator 'VERSION_GREATER_EQUAL' which isn't supported in older versions of cmake. The llvm website states that minimum required version of cmake for building llvm is 3.4.3 https://llvm.org/docs/CMake.html


Repository:
  rL LLVM

https://reviews.llvm.org/D57326

Files:
  unittests/Support/CMakeLists.txt


Index: unittests/Support/CMakeLists.txt
===================================================================
--- unittests/Support/CMakeLists.txt
+++ unittests/Support/CMakeLists.txt
@@ -90,7 +90,7 @@
   set_source_files_properties(AlignOfTest.cpp PROPERTIES COMPILE_FLAGS -w)
 endif()
 if(MSVC)
-  if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.15 )
+  if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 19.14 )
     # Since VS2017 15.8, the following snippet: Failed<CustomSubError>()
     # generates a warning:
     # \svn\llvm\utils\unittest\googlemock\include\gmock\gmock-matchers.h(186):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57326.183848.patch
Type: text/x-patch
Size: 599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190128/455116b8/attachment.bin>