[PATCH] D57320: [RISCV] Allow parsing immediates that use tilde

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 06:17:36 PST 2019


asb added a comment.

In D57320#1373523 <https://reviews.llvm.org/D57320#1373523>, @lewis-revill wrote:

> In D57320#1373431 <https://reviews.llvm.org/D57320#1373431>, @jrtc27 wrote:
>
> > There's also `AsmToken::Exclaim` for logical not that we could allow (although that's not one I've ever seen in real-world assembly). Please add tests for the CSR change?
>
>
> It would probably be good to add that for completeness. machine-csr-names.s seems a good place to add CSR tests?


I'd put it in rv32i-valid.s.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57320/new/

https://reviews.llvm.org/D57320





More information about the llvm-commits mailing list