[PATCH] D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT

Dimitry Andric via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 04:03:09 PST 2019


dim marked an inline comment as done.
dim added inline comments.


================
Comment at: ELF/ScriptParser.cpp:96
   SymbolAssignment *readAssignment(StringRef Tok);
-  std::tuple<ELFKind, uint16_t, bool> readBfdName();
+  std::tuple<ELFKind, uint16_t, uint8_t, bool> readBfdName();
   void readSort();
----------------
grimar wrote:
> I think we want to start using a new struct instead of tuple then.
Yeah, this is the disadvantage of unnamed tuples. I'll make a it a struct.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57283/new/

https://reviews.llvm.org/D57283





More information about the llvm-commits mailing list