[PATCH] D57051: [llvm-objdump] - Implement the --adjust-vma option.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 28 02:49:17 PST 2019
grimar marked 2 inline comments as done.
grimar added inline comments.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1374
// Stop when rel_cur's address is past the current instruction.
if (Offset >= Index + Size)
----------------
jhenderson wrote:
> Unrelated nit: There are a couple of issues with this comment, namely it uses a stale variable name, and "address" instead of "offset".
Fixed in rl352348.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57051/new/
https://reviews.llvm.org/D57051
More information about the llvm-commits
mailing list