[PATCH] D57146: [llvm-objdump] - Print LMAs when dumping section headers.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 02:32:45 PST 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:183
 
+cl::opt<bool>
+    ShowLMA("show-lma",
----------------
jhenderson wrote:
> Can this be `static`?
I think so. Probably all of `cl::opt<bool>` should be static in this file, though they are not now. I followed for consistency but seems that was not a good idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57146/new/

https://reviews.llvm.org/D57146





More information about the llvm-commits mailing list