[PATCH] D57229: [obj2yaml] - Dump the sh_entsize section field.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/elf-ent-size.yaml:1
+# RUN: yaml2obj %s -o %t
+# RUN: obj2yaml %t | FileCheck %s
----------------
Nit: rename the test elf-entsize.yaml, since entsize is all one "word" in the field name.


================
Comment at: test/tools/obj2yaml/elf-ent-size.yaml:12
+
+--- !ELF
+FileHeader:
----------------
You can simplify this somewhat by a) getting rid of the .text section, b) getting rid of the symbol, and c) removing the content and AddressAlign fields from the .rodata.cst4 section.


================
Comment at: tools/obj2yaml/elf2yaml.cpp:321
+  if (Shdr->sh_entsize)
+    S.EntSize = (llvm::yaml::Hex64)Shdr->sh_entsize;
 
----------------
Why are we casting this, but none of the other fields?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57229/new/

https://reviews.llvm.org/D57229