[PATCH] D57292: [LLD] [COFF] Add support for the new relocations IMAGE_REL_ARM{, 64}_REL32

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: COFF/Chunks.cpp:201
   case IMAGE_REL_ARM_SECREL:    applySecRel(this, Off, OS, S); break;
+  case IMAGE_REL_ARM_REL32:     add32(Off, S - P - 4); break;
   default:
----------------
pcc wrote:
> Are you sure that this is `S` and not `SX`?
Oh, great catch. Indeed, this should be `SX`, after crosschecking with link.exe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57292/new/

https://reviews.llvm.org/D57292