[PATCH] D57277: [COFF, ARM64] Don't put jump table into a separate COFF section for EK_LabelDifference32
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 26 12:03:22 PST 2019
mstorsjo added a comment.
Please upload your diffs with extra context (`diff -U99999`), to allow browsing the surrounding code here on phabricator.
The code change looks good to me, but I'm a little wary about the test; while it uses a CHECK-NEXT on the spot where there previously was a `.section .rdata, "dr"`. Maybe make the line for `.LJTI0_0` a CHECK-NEXT and it's at least a bit clearer that there really is no `.section` between the last instruction and the jump table itself.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57277/new/
https://reviews.llvm.org/D57277
More information about the llvm-commits
mailing list