[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 22:21:58 PST 2019


nickdesaulniers added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2533
+
+  assert(isa<InlineAsm>(Callee) && "Only know how to handle inlineasm callbr");
+  visitInlineAsm(&I);
----------------
needs a `(void)Callee;` otherwise release builds produce:
```
../lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2531:16: warning: unused variable 'Callee' [-Wunused-variable]
  const Value *Callee(I.getCalledValue());
               ^
```
or can the whole expression just fit in the assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765





More information about the llvm-commits mailing list