[PATCH] D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 19:50:59 PST 2019


chandlerc added a comment.

(peanut gallery comments)



================
Comment at: lib/Analysis/AliasSetTracker.cpp:179
 ///
-bool AliasSet::aliasesPointer(const Value *Ptr, LocationSize Size,
-                              const AAMDNodes &AAInfo,
-                              AliasAnalysis &AA) const {
+AliasResult AliasSet::aliasesPointer(const Value *Ptr, LocationSize Size,
+                                     const AAMDNodes &AAInfo,
----------------
reames wrote:
> The changes in signature to this function are obviously useful regardless of the rest of the patch.  Feel free to separate them and commit without further review.
+1, happy to see that factored out.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56568/new/

https://reviews.llvm.org/D56568





More information about the llvm-commits mailing list