[PATCH] D57187: [GlobalISel] Add ISel support for @llvm.lifetime.start and @llvm.lifetime.end for opt levels above O0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:798
+  case Intrinsic::lifetime_end: {
+    // No stack colouring in O0, discard region information.
+    if (MF->getTarget().getOptLevel() == CodeGenOpt::None)
----------------
The pass name is spelled in American


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:812
+    // static alloca. Quit if we find a non-static alloca.
+    for (Value *&V : Allocas) {
+      AllocaInst *AI = dyn_cast_or_null<AllocaInst>(V);
----------------
Reference unnecessary


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:813
+    for (Value *&V : Allocas) {
+      AllocaInst *AI = dyn_cast_or_null<AllocaInst>(V);
+      if (!AI)
----------------
I don't think GetUnderlyingObjects ever returns null values?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57187/new/

https://reviews.llvm.org/D57187