[PATCH] D57264: Bump minimum toolchain version

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 16:56:17 PST 2019


jfb marked 2 inline comments as done.
jfb added inline comments.


================
Comment at: CMakeLists.txt:26
 endif()
+if(NOT DEFINED LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN)
+  set(LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN OFF)
----------------
smeenai wrote:
> jfb wrote:
> > smeenai wrote:
> > > Might wanna make this an option and define it with all the other options?
> > What do you mean?
> I meant a CMake option, similar to how `LLVM_FORCE_USE_OLD_HOST_TOOLCHAIN` (which appears unused now) is defined: https://reviews.llvm.org/diffusion/L/browse/llvm/trunk/CMakeLists.txt$386-387
Ah gotcha! Fixed (and drive-by fix `LLVM_FORCE_USE_OLD_HOST_TOOLCHAIN` to `LLVM_FORCE_USE_OLD_TOOLCHAIN`).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264





More information about the llvm-commits mailing list