[PATCH] D57197: [GlobalISel][AArch64] Add support for @llvm.cos and @llvm.sin intrinsics

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM, but can you add the changes to introduce a new opcode and IR translator test as a separate commit.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:227
+  case TargetOpcode::G_FSIN: {
     Type *HLTy = Size == 64 ? Type::getDoubleTy(Ctx) : Type::getFloatTy(Ctx);
     auto Status = simpleLibcall(MI, MIRBuilder, Size, HLTy);
----------------
Can you add a check while you're here to bail out if we have a Size > 64.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-cos.mir:77
+    ; CHECK-DAG: BL &cosf
+    ; CHECK-DAG: BL &cosf
+    ; CHECK-DAG: BL &cosf
----------------
These BL checks can just be normal CHECKs right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57197/new/

https://reviews.llvm.org/D57197