[PATCH] D57183: [COFF, ARM64] Fix localaddress to handle stack realignment
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 25 16:48:07 PST 2019
rnk added a comment.
> use FP:
>
> if (hasEHFunclets || hasVarSizedObjects || needsStackRealignment || hasLocalEscape ||
> hasCalls || isFrameAddressTaken || hasStackMap || hasPatchPoint || !MaxCallFrameSizeComputed ||
> MaxCallFrameSize > DefaultSafeSPDisplacement)
Should FP be used if `needsStackRealignment` is true and none of the other conditions are true? I would've expected that SP needs to be used, because FP points to the parameter space before the stack was realigned.
I suppose that it is correct to force a frame to use FP when `hasLocalEscape` is true, assuming we've already checked the conditions under which BP is needed.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57183/new/
https://reviews.llvm.org/D57183
More information about the llvm-commits
mailing list