[PATCH] D57139: GlobalISel: Fix creating MMOs with align 0

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:854
         .addMemOperand(MF->getMachineMemOperand(
-            MachinePointerInfo(Ptr), MachineMemOperand::MOStore, ListSize, 0));
+            MachinePointerInfo(Ptr), MachineMemOperand::MOStore, ListSize, 1));
     return true;
----------------
arsenm wrote:
> aemerson wrote:
> > Can we use DL.getABITypeAlignment() here?
> Probably? I don't know anything about vastart. I'm not sure why this has an MMO in the first place
vastart's argument is a target dependent pointer to a va_list object on the stack, so I think it's worth it to try to get the right alignment. That said, 1 is always safe so I think it's ok to use for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57139/new/

https://reviews.llvm.org/D57139