[PATCH] D57264: Bump minimum toolchain version
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 25 16:02:59 PST 2019
smeenai added inline comments.
================
Comment at: CMakeLists.txt:26
endif()
+if(NOT DEFINED LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN)
+ set(LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN OFF)
----------------
Might wanna make this an option and define it with all the other options?
================
Comment at: docs/GettingStarted.rst:303
- % wget https://ftp.gnu.org/gnu/gcc/gcc-4.8.2/gcc-4.8.2.tar.bz2
- % wget https://ftp.gnu.org/gnu/gcc/gcc-4.8.2/gcc-4.8.2.tar.bz2.sig
+ % gcc_version=5.2.0
+ % wget https://ftp.gnu.org/gnu/gcc/gcc-${gcc_version}/gcc-${gcc_version}.tar.bz2
----------------
Should this be 5.1?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57264/new/
https://reviews.llvm.org/D57264
More information about the llvm-commits
mailing list