[PATCH] D57134: [WebAssembly] Exception handling: Switch to the new proposal

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

overall it looks good; it's nice that this version is simpler.



================
Comment at: lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp:211
+// another tag, but for now we only test for __cpp_exception tag, and if it does
+// not match, i.e., it is a foreign exception, we rethrow it.
+//
----------------
Side question, do we currently just rethrow it immediately or do we run destructors first?


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:321
+  // 'catch' and 'extract_exception' should be the first instruction of a BB and
+  // cannot move.
+  if (Def->getOpcode() == WebAssembly::CATCH ||
----------------
Is there any danger of any other passes trying to move these instructions around?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57134/new/

https://reviews.llvm.org/D57134