[PATCH] D56931: lld-link: Store comdat selection in SectionChunk, reject more invalid associated comdats

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/InputFiles.cpp:229
 
-  if (Parent == PendingComdat) {
-    // This can happen if an associative comdat refers to another associative
-    // comdat that appears after it (invalid per COFF spec) or to a section
-    // without any symbols.
+  auto DiagAssoc = [&]() {
     StringRef Name, ParentName;
----------------
nit: since this function reads associative comdat sections, `Assoc` in a variable name seems redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56931/new/

https://reviews.llvm.org/D56931