[PATCH] D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 11:45:13 PST 2019


zturner added a comment.

Sorry about this, it slipped off my radar.

Two things I think we should do:

1. Dump these records as part of `llvm-pdbutil dump -fpo`

2. Using the results of #1, we can add a test for this.  Check in a very small PDB that was built with /nodefaultlib by linking in an assembly file with a `.debug$F` section (if you can't figure out how to produce one, libcmtd has some.  You can just use obj2yaml on them and strip out everything but the `.debug$F` section).  This resulting PDB shoudl have both new and old fpo records, then we can test the output using `llvm-pdbutil dump -fpo`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56725/new/

https://reviews.llvm.org/D56725





More information about the llvm-commits mailing list