[PATCH] D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts()

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 09:56:25 PST 2019


vsk added a comment.

I see a minor issue in the test, but the patch looks great to me otherwise. Thanks!



================
Comment at: test/CodeGen/SystemZ/debuginstr-cgp.mir:50
+#   call void @llvm.dbg.value(metadata %10* %tmp5, metadata !12, metadata !DIExpression()), !dbg !19
+#   %tmp6 = getelementptr inbounds %10, %10* %tmp5, i64 0, i32 0, !dbg !20
+#   call void @llvm.dbg.value(metadata %0* %tmp6, metadata !13, metadata !DIExpression()), !dbg !20
----------------
Something might have went wrong during the test update -- I think Wolfgang's comment about the missing bitcast applies again?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57050/new/

https://reviews.llvm.org/D57050





More information about the llvm-commits mailing list