[compiler-rt] r352220 - [scudo] Delay allocations in the RSS check test

Kostya Kortchinsky via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 09:23:29 PST 2019


Author: cryptoad
Date: Fri Jan 25 09:23:29 2019
New Revision: 352220

URL: http://llvm.org/viewvc/llvm-project?rev=352220&view=rev
Log:
[scudo] Delay allocations in the RSS check test

Summary:
D57116 fails on the armv7 bots, which is I assume due to the timing of
the RSS check on the platform. While I don't have a platform to test
that change on, I assume this would do.

The test could be made more reliable by either delaying more the
allocations, or allocating more large-chunks, but both those options
have a somewhat non negligible impact (more memory used, longer test).

Hence me trying to keep the additional sleeping/allocating to a
minimum.

Reviewers: eugenis, yroux

Reviewed By: yroux

Subscribers: javed.absar, kristof.beyls, delcypher, #sanitizers, llvm-commits

Differential Revision: https://reviews.llvm.org/D57241

Modified:
    compiler-rt/trunk/test/scudo/rss.c

Modified: compiler-rt/trunk/test/scudo/rss.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/scudo/rss.c?rev=352220&r1=352219&r2=352220&view=diff
==============================================================================
--- compiler-rt/trunk/test/scudo/rss.c (original)
+++ compiler-rt/trunk/test/scudo/rss.c Fri Jan 25 09:23:29 2019
@@ -30,7 +30,8 @@ static void *allocs[kNumAllocs];
 int main(int argc, char *argv[]) {
   int returned_null = 0;
   for (int i = 0; i < kNumAllocs; i++) {
-    if ((i & 0xf) == 0)
+    // sleep for 100ms every 8 allocations, to allow the RSS check to catch up.
+    if (i != 0 && (i & 0x7) == 0)
       usleep(100000);
     allocs[i] = malloc(kAllocSize);
     if (allocs[i])




More information about the llvm-commits mailing list