[PATCH] D57163: [DebugInfo][DAG] PR40427: Avoid accidentally re-ordering DBG_VALUEs due to assumptions about inst creation

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I think I could convince myself that this change is correct. Thanks!



================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:746
   unsigned Order = N->getIROrder();
-  if (!Order || !Seen.insert(Order).second) {
+  if (!Order || Seen.count(Order) != 0) {
     // Process any valid SDDbgValues even if node does not have any order
----------------
`if (!Order || Seen.count(Order)) {`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57163/new/

https://reviews.llvm.org/D57163