[PATCH] D57089: Provide reason messages for unviable inlining

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 07:45:22 PST 2019


yrouban marked an inline comment as done.
yrouban added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:2028
       return llvm::InlineCost::getAlways("always inline attribute");
-    return llvm::InlineCost::getNever("inapplicable always inline attribute");
+    return llvm::InlineCost::getNever(IsViable);
   }
----------------
xbolva00 wrote:
> getNever should take a string
//InlineResult// is implicitly converted to char* Reason.
Do you propose explicit //IsViable.message//?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57089/new/

https://reviews.llvm.org/D57089





More information about the llvm-commits mailing list