[llvm] r352206 - Revert r351954 "Add a value_type to ArrayRef."
Clement Courbet via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 25 07:25:52 PST 2019
Author: courbet
Date: Fri Jan 25 07:25:52 2019
New Revision: 352206
URL: http://llvm.org/viewvc/llvm-project?rev=352206&view=rev
Log:
Revert r351954 "Add a value_type to ArrayRef."
This breaks arm self-hosted buildbots.
Modified:
llvm/trunk/include/llvm/ADT/ArrayRef.h
llvm/trunk/unittests/ADT/ArrayRefTest.cpp
Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=352206&r1=352205&r2=352206&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)
+++ llvm/trunk/include/llvm/ADT/ArrayRef.h Fri Jan 25 07:25:52 2019
@@ -44,7 +44,6 @@ namespace llvm {
using const_iterator = const T *;
using size_type = size_t;
using reverse_iterator = std::reverse_iterator<iterator>;
- using value_type = typename std::remove_cv<T>::type;
private:
/// The start of the array, in an external buffer.
Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=352206&r1=352205&r2=352206&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Fri Jan 25 07:25:52 2019
@@ -51,14 +51,6 @@ static_assert(
"Assigning from an initializer list");
#endif
-// Check Typedefs.
-static_assert(
- std::is_same<ArrayRef<int>::value_type, int>::value,
- "erroneous value_type");
-static_assert(
- std::is_same<ArrayRef<const int>::value_type, int>::value,
- "erroneous value_type");
-
namespace {
TEST(ArrayRefTest, AllocatorCopy) {
More information about the llvm-commits
mailing list