[PATCH] D57224: [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 07:25:09 PST 2019


mgorny added a comment.

In D57224#1371281 <https://reviews.llvm.org/D57224#1371281>, @filcab wrote:

> Hah, I had the exact same fix on our private branch.
>
> I think this might create problems if you generate files from cmake and immediately run `ninja check-sanitizer` (without building the rest of llvm). Can you check if that works? If so, it's an LGTM.


if you are concerned about dependencies in non-standalone builds, they are handled separately from this. This addition was only done for `COMPILER_RT_STANDALONE_BUILD`.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57224/new/

https://reviews.llvm.org/D57224





More information about the llvm-commits mailing list