[PATCH] D57051: [llvm-objdump] - Implement the --adjust-vma option.
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jan 25 05:40:12 PST 2019
    
    
  
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1374
 
             // Stop when rel_cur's address is past the current instruction.
             if (Offset >= Index + Size)
----------------
Unrelated nit: There are a couple of issues with this comment, namely it uses a stale variable name, and "address" instead of "offset".
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57051/new/
https://reviews.llvm.org/D57051
    
    
More information about the llvm-commits
mailing list