[PATCH] D57225: Don't run misc-non-private-member-variables-in-classes check on LLVM.

[Haojian Wu via Phabricator via llvm-commits]

hokein created this revision.
hokein added a reviewer: alexfh.
Herald added subscribers: llvm-commits, kadircet, ioeric, ilya-biryukov.

The check adds too much nosie on LLVM codebase (especially running clangd
with clang-tidy enabled).

The check seems too aggresive, it will give warnings as long as a struct
has a method, e.g.

struct Foo {

  int X;
  void f() {};

};


Repository:
  rL LLVM

https://reviews.llvm.org/D57225

Files:
  .clang-tidy


Index: .clang-tidy
===================================================================
--- .clang-tidy
+++ .clang-tidy
@@ -1,4 +1,4 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57225.183510.patch
Type: text/x-patch
Size: 492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190125/9ea53e71/attachment.bin>