[PATCH] D57146: [llvm-objdump] - Print LMAs when dumping section headers.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 03:06:10 PST 2019


grimar added a comment.

In D57146#1370968 <https://reviews.llvm.org/D57146#1370968>, @jhenderson wrote:

> One further suggestion for 1) might be to change the header to VMA/LMA for the address column, to make it clearer. It might be less confusing to those used to GNU output?


I thought about that too. Decided to not suggest it because if we hide a LMA column completely then probably no need to make people who are unfamiliar with it even to think about it?
I.e. This patch prints "VMA ... LMA" now and "Address" in another case. I supposed that just "Address" would look simpler then.

I am not sure what would be really better though honestly. Maybe mixing "VMA" and "Address" for different cases is also not a very good idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57146/new/

https://reviews.llvm.org/D57146





More information about the llvm-commits mailing list