[PATCH] D57224: [CMake] Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz created this revision.
sgraenitz added reviewers: filcab, mgorny.
Herald added a subscriber: Sanitizers.

The issue came up during release testing for LLVM 8: https://bugs.llvm.org/show_bug.cgi?id=40443
This patch fixes the said CMake failure, so compiler-rt builds successfully.

Running its test suite doesn't succeed though -- may be related to this CMake warning:

  CMake Warning at cmake/Modules/CompilerRTUtils.cmake:261 (message):
    testingsupport library not installed, some tests will be skipped
  Call Stack (most recent call first):
    CMakeLists.txt:69 (load_llvm_config)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D57224

Files:
  test/CMakeLists.txt


Index: test/CMakeLists.txt
===================================================================
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -14,10 +14,6 @@
   list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS profile)
 endif()
 
-if(COMPILER_RT_STANDALONE_BUILD)
-  list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS FileCheck)
-endif()
-
 # When ANDROID, we build tests with the host compiler (i.e. CMAKE_C_COMPILER),
 # and run tests with tools from the host toolchain.
 if(NOT ANDROID)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57224.183508.patch
Type: text/x-patch
Size: 480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190125/5cd176d7/attachment.bin>