[PATCH] D57115: [llvm] Remove dependency on <algorithm> [NFC]

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 11:19:10 PST 2019


mgrang abandoned this revision.
mgrang added a comment.

In D57115#1369773 <https://reviews.llvm.org/D57115#1369773>, @dblaikie wrote:

> In D57115#1369756 <https://reviews.llvm.org/D57115#1369756>, @mgrang wrote:
>
> > I wanted to clean up the inclusions of algorithm due to std::sort. But seems like this change may potentially break some things. So for now we can let it pass? (Meaning I can abandon this patch).
>
>
> Yep - thanks for trying, but unless you can get something like IWYU working to help ensure this cleanup is a bit more robust - I'd probably suggest just abandoning this change, unfortunately.


Thanks a lot David. I will definitely try IWYU when I have time. Abandoning this patch now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57115/new/

https://reviews.llvm.org/D57115





More information about the llvm-commits mailing list