[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In D56624#1370607 <https://reviews.llvm.org/D56624#1370607>, @yln wrote:

> In D56624#1370579 <https://reviews.llvm.org/D56624#1370579>, @eugenis wrote:
>
> > Maybe the frontend should insert __asan_handle_noreturn whenever ASan is enabled, and then ASan would not care about the attribute? I'd like to avoid having this logic in two places.
>
>
> +1 for this. @vsk Can you sign off on this design?


Sounds good to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56624/new/

https://reviews.llvm.org/D56624