[PATCH] D57192: simplify COFF module assembly test and move it to Object

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 16:33:58 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL352142: simplify COFF module assembly test and move it to Object (authored by inglorion, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D57192?vs=183429&id=183440#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57192/new/

https://reviews.llvm.org/D57192

Files:
  llvm/trunk/test/MC/COFF/module-asm-coff.ll
  llvm/trunk/test/Object/X86/coff-asm.ll


Index: llvm/trunk/test/Object/X86/coff-asm.ll
===================================================================
--- llvm/trunk/test/Object/X86/coff-asm.ll
+++ llvm/trunk/test/Object/X86/coff-asm.ll
@@ -0,0 +1,13 @@
+; Check that llvm-nm doesn't crash on COFF-specific assembly directives
+; (PR36789).
+
+; RUN: llvm-as %s -o %t.bc
+; RUN: llvm-nm %t.bc
+
+target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-windows-msvc19.0.24210"
+
+module asm ".text"
+module asm ".def foo; .scl 2; .type 32; .endef"
+module asm "foo:"
+module asm "  ret"
Index: llvm/trunk/test/MC/COFF/module-asm-coff.ll
===================================================================
--- llvm/trunk/test/MC/COFF/module-asm-coff.ll
+++ llvm/trunk/test/MC/COFF/module-asm-coff.ll
@@ -1,21 +0,0 @@
-; Tests COFF-specific directives in module level assembly.
-
-; RUN: llc -filetype=obj %s -o %t.obj
-; RUN: llvm-readobj -t %t.obj | FileCheck %s
-; RUN: opt -thinlto-bc %s -o %t.thinlto.bc
-; RUN: llvm-lto2 run %t.thinlto.bc -o %t.thinlto.obj -r=%t.thinlto.bc,foo,plx
-; RUN: llvm-readobj -t %t.thinlto.obj.1 | FileCheck %s
-
-target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-pc-windows-msvc19.0.24210"
-
-module asm ".text"
-module asm ".def foo; .scl 3; .type 32; .endef"
-module asm ".global foo"
-module asm "foo:"
-module asm "  ret"
-
-; CHECK: Symbol {
-; CHECK:   Name: foo
-; CHECK:   StorageClass:
-; CHECK-SAME: Static (0x3)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57192.183440.patch
Type: text/x-patch
Size: 1484 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190125/a7a58e94/attachment.bin>


More information about the llvm-commits mailing list