[PATCH] D57191: gn build: Build clang with -fno-strict-aliasing, make building with gcc much quieter

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM

In D57191#1370152 <https://reviews.llvm.org/D57191#1370152>, @thakis wrote:

> I'm getting a bunch of
>
>   [1593/1698] CXX stage2_unix/obj/compiler-rt/lib/sanitizer_common/sources.sanitizer_platform_limits_solaris.o
>   warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
>   1 warning generated.
>
>
> in my local build with this patch applied. Does the stage2_unix toolchain set is_clang to true? If not, it probably should?


Agreed, sent D57202 <https://reviews.llvm.org/D57202>.



================
Comment at: llvm/utils/gn/build/BUILD.gn:153
 config("clang_code") {
+  if (host_os != "win") {
+    cflags = [ "-fno-strict-aliasing" ]
----------------
current_os?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57191/new/

https://reviews.llvm.org/D57191