[PATCH] D57192: simplify COFF module assembly test and move it to Object

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/test/Object/X86/coff-asm.ll:3-4
 
 ; RUN: llc -filetype=obj %s -o %t.obj
-; RUN: llvm-readobj -t %t.obj | FileCheck %s
+; RUN: llvm-nm %t.obj | FileCheck %s
 ; RUN: opt -thinlto-bc %s -o %t.thinlto.bc
----------------
inglorion wrote:
> pcc wrote:
> > Don't you just need these two lines to test your change? The change makes it so that llvm-nm doesn't crash on this input, right?
> llvm-nm doesn't crash here (or in the next invocation, for that matter) even without D57073. Does it use RecordStreamer? My impression was the crashing code path is only invoked when reading in module assembly in ModuleSymbolTable.
It should be using RecordStreamer via IRObjectFile.

My mistake, I didn't notice that you were calling llc here. You should be able to reproduce the problem by running `llvm-nm` on the file that you're calling `%t.thinlto.bc` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57192/new/

https://reviews.llvm.org/D57192