[PATCH] D57082: [HotColdSplit] Move splitting earlier in the pipeline

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Test fails on Windows: https://logs.chromium.org/logs/chromium/bb/tryserver.chromium.win/win_upload_clang/467/+/recipes/steps/package_clang/0/stdout

  FAIL: LLVM :: Other/opt-hot-cold-split.ll (36787 of 46358)
  ******************** TEST 'LLVM :: Other/opt-hot-cold-split.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE -mtriple=x86_64-- -Os -hot-cold-split=true -debug-pass=Structure < C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -o /dev/null 2>&1 | C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -check-prefix=DEFAULT-Os
  : 'RUN: at line 2';   C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE -mtriple=x86_64-- -Os -hot-cold-split=true -passes='lto-pre-link<Os>' -debug-pass-manager < C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -o /dev/null 2>&1 | C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -check-prefix=LTO-PRELINK-Os
  : 'RUN: at line 3';   C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE -mtriple=x86_64-- -Os -hot-cold-split=true -passes='thinlto-pre-link<Os>' -debug-pass-manager < C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -o /dev/null 2>&1 | C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -check-prefix=THINLTO-PRELINK-Os
  : 'RUN: at line 4';   C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE -mtriple=x86_64-- -Os -hot-cold-split=true -passes='thinlto<Os>' -debug-pass-manager < C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -o /dev/null 2>&1 | C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll -check-prefix=THINLTO-POSTLINK-Os
  --
  Exit Code: 1
  
  Command Output (stdout):
  --
  $ ":" "RUN: at line 1"
  $ "C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE" "-mtriple=x86_64--" "-Os" "-hot-cold-split=true" "-debug-pass=Structure" "-o" "/dev/null"
  $ "C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE" "C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll" "-check-prefix=DEFAULT-Os"
  $ ":" "RUN: at line 2"
  $ "C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\opt.EXE" "-mtriple=x86_64--" "-Os" "-hot-cold-split=true" "-passes=lto-pre-link<Os>" "-debug-pass-manager" "-o" "/dev/null"
  $ "C:\b\rr\tmpgtkggu\w\src\third_party\llvm-bootstrap\bin\FileCheck.EXE" "C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll" "-check-prefix=LTO-PRELINK-Os"
  # command stderr:
  C:\b\rr\tmpgtkggu\w\src\third_party\llvm\test\Other\opt-hot-cold-split.ll:15:19: error: LTO-PRELINK-Os: expected string not found in input
  ; LTO-PRELINK-Os: Running pass: ModuleToFunctionPassAdaptor<llvm::PromotePass>
                    ^
  <stdin>:3:1: note: scanning from here
  Running pass: VerifierPass on <stdin>
  ^
  <stdin>:17:1: note: possible intended match here
  Running pass: ModuleToFunctionPassAdaptor<class llvm::PromotePass> on <stdin>

(note additional "class ")


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57082/new/

https://reviews.llvm.org/D57082