[PATCH] D57192: simplify COFF module assembly test and move it to Object

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 14:29:28 PST 2019


pcc added inline comments.


================
Comment at: llvm/test/Object/X86/coff-asm.ll:3-4
 
 ; RUN: llc -filetype=obj %s -o %t.obj
-; RUN: llvm-readobj -t %t.obj | FileCheck %s
+; RUN: llvm-nm %t.obj | FileCheck %s
 ; RUN: opt -thinlto-bc %s -o %t.thinlto.bc
----------------
Don't you just need these two lines to test your change? The change makes it so that llvm-nm doesn't crash on this input, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57192/new/

https://reviews.llvm.org/D57192





More information about the llvm-commits mailing list