[PATCH] D57173: [opaque pointer types] Pass value type to GetElementPtr creation.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 14:24:49 PST 2019


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good - thanks!



================
Comment at: llvm/include/llvm/IR/Constants.h:1153
   /// \param OnlyIfReducedTy see \a getWithOperands() docs.
+  static Constant *getGetElementPtr(std::nullptr_t, Constant *C,
+                                    ArrayRef<Constant *> IdxList,
----------------
What overload sets are these nullptr+delete versions meant to account for?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57173/new/

https://reviews.llvm.org/D57173





More information about the llvm-commits mailing list