[PATCH] D56548: Fix emission of _fltused for MSVC.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 13:34:04 PST 2019


jyknight added a comment.

In D56548#1369995 <https://reviews.llvm.org/D56548#1369995>, @jyknight wrote:

> The _fltused symbol being required in those two compilations is expected behavior. What I'm not sure about is why those two tests don't see any definition of the _fltused symbol? I guess they don't link against the C runtime?


Oh, of course they don't, because they're intended to work on all platforms. I've fixed the tests in r352110 by just defining the symbol. I believe that's the correct fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56548/new/

https://reviews.llvm.org/D56548





More information about the llvm-commits mailing list