[PATCH] D56548: Fix emission of _fltused for MSVC.

Thu Jan 24 11:51:58 PST 2019

thakis added a comment.

On https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923423461858190016/+/steps/package_clang/0/stdout I'm getting:

  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90
  FAIL: lld :: COFF/lto-new-symbol.ll (43503 of 45323)
  ******************** TEST 'lld :: COFF/lto-new-symbol.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/llvm-as -o /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-new-symbol.ll.tmp.obj /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/tools/lld/test/COFF/lto-new-symbol.ll
  : 'RUN: at line 3';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/lld-link /out:/b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-new-symbol.ll.tmp.exe /entry:foo /subsystem:console /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-new-symbol.ll.tmp.obj
  --
  Exit Code: 1

  Command Output (stderr):
  --
  lld-link: error: undefined symbol: _fltused
  >>> referenced by lto.tmp

  --

  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.
  FAIL: lld :: COFF/lto-lazy-reference.ll (43516 of 45323)
  ******************** TEST 'lld :: COFF/lto-lazy-reference.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/llc -mtriple=i686-pc-windows-msvc -filetype=obj -o /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference-quadruple.obj /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/tools/lld/test/COFF/Inputs/lto-lazy-reference-quadruple.ll
  : 'RUN: at line 3';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/llvm-as -o /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference-dummy.bc /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/tools/lld/test/COFF/Inputs/lto-lazy-reference-dummy.ll
  : 'RUN: at line 4';   rm -f /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.lib
  : 'RUN: at line 5';   llvm-ar cru /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.lib /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference-quadruple.obj /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference-dummy.bc
  : 'RUN: at line 6';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/llvm-as -o /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.obj /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/tools/lld/test/COFF/lto-lazy-reference.ll
  : 'RUN: at line 7';   /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/bin/lld-link /out:/b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.exe /entry:main /subsystem:console /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.obj /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm-bootstrap/tools/lld/test/COFF/Output/lto-lazy-reference.ll.tmp.lib
  --
  Exit Code: 1

  Command Output (stderr):
  --
  lld-link: error: undefined symbol: __fltused
  >>> referenced by lto.tmp

Could that be due to this change?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56548/new/

https://reviews.llvm.org/D56548