[PATCH] D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D57083#1369028 <https://reviews.llvm.org/D57083#1369028>, @jhenderson wrote:

> In D57083#1368695 <https://reviews.llvm.org/D57083#1368695>, @pcc wrote:
>
> > llvm-symbolizer has a totally different interface to addr2line. Does it really make sense to make llvm-symbolizer similar in this way or should there be a separate tool that tries to be compatible with addr2line?
>
>
> I'm not sure it's that dissimilar is it? Following the recent changes, I think it is pretty close to a drop-in replacement. What differences are you concerned about in particular?


Okay, I didn't see the most recent changes.

I think my main concern is the difference in output format. For llvm-symbolizer we have:

  $ bin/llvm-symbolizer -e ../d/bin/llvm-tblgen 0x7dd050 
  main
  /usr/local/google/home/pcc/l/d/../llvm/utils/TableGen/TableGen.cpp:246:0

While for addr2line we have:

  $ addr2line -e ../d/bin/llvm-tblgen 0x7dd050 
  /usr/local/google/home/pcc/l/d/../llvm/utils/TableGen/TableGen.cpp:246

The sanitizers (and various other tools, e.g. https://chromium-review.googlesource.com/c/android_ndk/+/952475 ) depend on the current default llvm-symbolizer output format, and presumably users of addr2line depend on the default output format of that tool as well. So it makes much more sense to me for the addr2line compatibility features to be either part of a separate tool or be busyboxed into the current llvm-symbolizer binary, similar to llvm-ar/llvm-lib.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57083/new/

https://reviews.llvm.org/D57083