[PATCH] D54653: [IRBuilder] Remove positivity check from CreateAlignmentAssumption()

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 11:35:11 PST 2019


jyknight added a comment.

I'd like to see the rule we ended up with documented somewhere.

That is:

> When the pointer is non-null, then the alignment must be a positive power of 2 (otherwise UB).

It's not necessarily obvious that the UBness of invalid alignments ought to be conditional upon the pointer's value.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54653/new/

https://reviews.llvm.org/D54653





More information about the llvm-commits mailing list