[PATCH] D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

I like this patch, and I like the DominatorTree clean up/refactor.  As you pointed out, your patch does make the DT required, which makes sense because your solution must make use of that analysis.  I don't see that as an issue.  Overall, this patch makes sense to me, but I'm curious as to what others think.



================
Comment at: lib/CodeGen/StackProtector.cpp:161
+    // Don't bother examining the user if it's in a basic block that isn't
+    // reachable from the entry BB. That code will probably be removed laster
+    // anyway, and in in case it won't be executed so we don't need to care
----------------
s/laster/later/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57149/new/

https://reviews.llvm.org/D57149