[PATCH] D57146: [llvm-objdump] - Print LMAs when dumping section headers.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

In D57146#1369140 <https://reviews.llvm.org/D57146#1369140>, @jhenderson wrote:

> The code change looks basically fine, but I'm wondering if we really want this? For many (most?) use cases, the LMA is the same as the VMA, so the extra column is just useless noise. I know we want to broadly be consistent with GNU tools, but I wonder if that's the case when it doesn't make that much sense?
>
> What do you think about the following approach:
>
> 1. If there are any segments with different p_vaddr and p_paddr, go with your suggestion.
> 2. If a user specifies a switch, e.g. --show-lma, also go with your suggestion.
> 3. Otherwise, only print the VMA.
>
>   The issue with this is that it might break parsers which are written against GNU objdump's behaviour. I'm not sure if this is an issue or not? The switch is designed to mitigate that problem.
>
>   It's probably worth getting some others to give their opinion on this.


+1 for this proposal. I find the GNU format extremely dense and hard to mentally parse as is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57146/new/

https://reviews.llvm.org/D57146