[PATCH] D57143: [builtins] Rounding mode support for addxf3/subxf3

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 09:29:36 PST 2019


efriedma added inline comments.


================
Comment at: compiler-rt/lib/builtins/arm/fp_mode.c:25
+  uint32_t fpscr;
+  __asm__ __volatile__("vmrs  %0, fpscr" : "=r" (fpscr));
+  fpscr = fpscr >> ARM_RMODE_SHIFT & ARM_RMODE_MASK;
----------------
This needs to be guarded; vmrs is only valid on targets which support VFP.  Not sure if we need to try to check that at runtime...


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57143/new/

https://reviews.llvm.org/D57143





More information about the llvm-commits mailing list