[PATCH] D57138: [RS4GC] Avoid crashing on gep scalar, vector_idx

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 07:44:32 PST 2019


anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments.



================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:2628
+          MadeChange = true;
+        }
+    }
----------------
do you think it makes sense to add an assert here as the else part:
```
else {
   assert(VF == I.getOperand(i)->getType()->getVectorNumElements() && "expected same VF for all operands!");
}
```
Btw, this property is also verified in the IRVerifier when we come across a vector GEP (vector GEP is one where *any* of the GEP operands is a vector type).



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57138/new/

https://reviews.llvm.org/D57138





More information about the llvm-commits mailing list