[PATCH] D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts()
Jonas Paulsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 24 06:45:16 PST 2019
jonpa added a comment.
In D57050#1368089 <https://reviews.llvm.org/D57050#1368089>, @wolfgangp wrote:
> The test case looks much better now, thanks.
>
> Usually we include a short set of instructions in the test case on how to produce the IR, including the source code, in case the IR needs to be re-generated in response to a format change etc.
>
> Other than that, LGTM.
I was not aware of that... The Debug info is just all "dummy" which has just been copied-and-pasted into the test case. I'm afraid I think my .ll test case is gone at the moment. Do you really need me to regenerate it, or could it be accepted given its small size?
(I don't think reducing the source input is meaningful given that the debug-info is not "real", right?)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57050/new/
https://reviews.llvm.org/D57050
More information about the llvm-commits
mailing list