[PATCH] D57151: [llvm-symbolizer] Add switch to adjust addresses by fixed offset

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-symbolizer/adjust-vma.s:18
+# Show that we can handle addresses less than the offset.
+# RUN: llvm-symbolizer 0xa --print-address --adjust-vma 0xb --obj=%t.o \
+# RUN:   | FileCheck %s --check-prefix=OVERFLOW
----------------
jhenderson wrote:
> grimar wrote:
> > I would probably suggest to do:
> > `llvm-symbolizer 0xa 0xb --print-address --adjust-vma 0x100`
> > 
> > That way it would be easy to match this invocation with one used in the first test and see a difference in result.
> > 
> > I have no strong preference, just was a bit confused with `0xb` at first, because it was already used as
> > an address in the previous test and my brain tried to match it with it :)
> I can understand the confusion. That's what I did originally, but a colleague suggested that I change the offset to 0xa to test the case where the calculation only just overflows. How about the following:
> 
> `llvm-symbolizer 0xa 0xb --print-address --adjust-vma 0xc`
Yeah, that will also work, thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57151/new/

https://reviews.llvm.org/D57151