[PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

[Tatyana Krasnukha via Phabricator via llvm-commits]

tatyana-krasnukha added inline comments.


================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:1-8
+//===-- ArchitectureArc.cpp -------------------------------------*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
----------------
clayborg wrote:
> Does this file need to exist anymore? If not remove it. If so, fill in at least one virtual function that is needed.
It's needed to not keep static functions implementation in the header file. And it will definitely be required when I'll implement `GetBreakableLoadAddress` to handle delay slots, but this will not be in this revision.


================
Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.h:34
+
+  void OverrideStopInfo(Thread &thread) const override {}
+
----------------
clayborg wrote:
> Are we missing this? Any reason for this to exist? If this function need to doesn't exist then this ArchitectureArc class doesn't need to exist and can be removed.
It's because `OverrideStopInfo` is a pure virtual function. No one but `ArchitectureArm` really needs to override this. I'll be glad to replace `= 0` in the base class with the empty body (by a separate commit). 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718