[PATCH] D57084: hwasan: Read shadow address from ifunc if we don't need a frame record.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 23 14:34:48 PST 2019
pcc marked 2 inline comments as done.
pcc added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:165
+ cl::desc("allow the use of ifunc"),
+ cl::Hidden, cl::init(true));
+
----------------
eugenis wrote:
> Ifunc is known to be broken in static binaries on android.
> This needs to be false by default.
Done. I guess we can use API level to default this at some point.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57084/new/
https://reviews.llvm.org/D57084
More information about the llvm-commits
mailing list